Skip to content

Conversation

@himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Jul 29, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/16576

This PR fixes the issue where custom comment form fields added via the fields parameter are only visible to non-logged-in users. Logged-in users should be able to use custom comment fields. Currently, only default WordPress fields (author, email, and url) are hidden for logged-in users since this data comes from their profile, but custom fields should remain visible.

This PR modifies the field processing logic in comment_form() to show custom fields to both logged-in and non-logged-in users, while continuing to hide default WordPress fields for logged-in users.

Testing Instructions

  1. Add custom fields to the comment form using the fields parameter
  2. Test as both a logged-in and a non-logged-in user
  3. Verify custom fields appear for both user types
  4. Verify that default fields (author, email, url) only appear for non-logged-in users

Screenshots

User Type Before After
Logged-in User Before - Logged-in user After - Logged-in user
Non-logged-in User Before - Non-logged-in user After - Non-logged-in user

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95 himanshupathak95 force-pushed the fix/16576-comment-form-fields branch from 71418c1 to 46f2eb0 Compare August 4, 2025 16:18
@himanshupathak95 himanshupathak95 marked this pull request as ready for review August 4, 2025 16:20
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@himanshupathak95 himanshupathak95 force-pushed the fix/16576-comment-form-fields branch from 46f2eb0 to dec09bd Compare August 13, 2025 16:19
@himanshupathak95 himanshupathak95 force-pushed the fix/16576-comment-form-fields branch from dec09bd to c0c0201 Compare September 4, 2025 09:39
@himanshupathak95
Copy link
Author

Committed in [61034]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant