General: Prevent php warning for not readable files#9311
General: Prevent php warning for not readable files#9311Ninos wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
62b0266 to
2088397
Compare
|
How would site admins, or log monitoring tools, know when there's a file read error if we suppress errors? |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
For me such error output only makes sense for files which must be readable. The function parses all php-files in theme's subdirectories, not only template files, also which are not relevant for templating. Would be better to have some predefined folders (theme dir, /templates, ...) for parsing (also for performance reasons), but this would may break compatibility with some themes. |
Having unreadable php-files in theme-directory triggers following php-warning:
This PR hardens the
get_post_templates()function a bit.Trac:
https://core.trac.wordpress.org/ticket/63743