Backport: update theme.json to inherit button styles on frontend#9268
Backport: update theme.json to inherit button styles on frontend#9268shrivastavanolo wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Test ReportDescriptionThis report validates whether the indicated patch works as expected. PR tested: #9268 The patch updates the theme.json file to include additional typography styles (fontStyle, fontWeight, letterSpacing, textTransform) for button elements, all set to "inherit". This ensures buttons correctly inherit typography settings applied globally via Site Editor. Environment
Actual Results
- After patch:
✅ Issue resolved. Buttons now correctly inherit all specified typography settings from the root level. Additional Notes
|
This PR syncs the changes initially added to Gutenberg in WordPress/gutenberg#70676. See #9268. See https://core.trac.wordpress.org/ticket/63700. Fixes #63700. git-svn-id: https://develop.svn.wordpress.org/trunk@61021 602fd350-edb4-49c9-b593-d223f7449a82
This PR syncs the changes initially added to Gutenberg in WordPress/gutenberg#70676. See WordPress/wordpress-develop#9268. See https://core.trac.wordpress.org/ticket/63700. Fixes #63700. Built from https://develop.svn.wordpress.org/trunk@61021 git-svn-id: https://core.svn.wordpress.org/trunk@60357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This PR syncs the changes initially added to Gutenberg in WordPress/gutenberg#70676. See WordPress/wordpress-develop#9268. See https://core.trac.wordpress.org/ticket/63700. Fixes #63700. Built from https://develop.svn.wordpress.org/trunk@61021 git-svn-id: http://core.svn.wordpress.org/trunk@60357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2 participants
Part of: WordPress/gutenberg#60403
Backport for: WordPress/gutenberg#70676
The provided code change updates the
theme.jsonfile to include additional typography styles for button elements. Specifically, it adds "fontStyle", "fontWeight", "letterSpacing", and "textTransform" properties with a value of "inherit". This change aims to address an issue where these styles were not being applied to button elements, despite being set at the root level via Global Styles. The issue was reproducible by updating typography styles in the Site Editor and inserting a Search block, which did not display the expected styles on the front end.Testing Instructions
Screenshots or screencast
Before
After
Trac ticket:
https://core.trac.wordpress.org/ticket/63700
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.