Skip to content

feat: Dynamically add CSS styles for colors in color pallete.#9261

Open
coder-rancho wants to merge 3 commits intoWordPress:trunkfrom
coder-rancho:feature/dynamically-add-css-classes-for-color-pallete
Open

feat: Dynamically add CSS styles for colors in color pallete.#9261
coder-rancho wants to merge 3 commits intoWordPress:trunkfrom
coder-rancho:feature/dynamically-add-css-classes-for-color-pallete

Conversation

@coder-rancho
Copy link
Copy Markdown

@coder-rancho coder-rancho commented Jul 14, 2025

This pull request adds a new function to dynamically generate CSS classes for the theme's editor color palette in the Twentynineteen WordPress theme. The function ensures that text, background, and border color classes are created based on the theme's defined color palette and applies them as inline styles.

Trac ticket: https://core.trac.wordpress.org/ticket/63623

Screenshots

Before After
Editor image image
Frontend image image

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 14, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vyasnaman, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

$css = '';

foreach ( $colors as $color ) {
// Generate text color classes
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Generate text color classes
// Generate text color classes.

Fix for other inline comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for all inline comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants