HTML API: Rely on HTML API in oEmbed filtering tests.
#9259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 13, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
4835d3f to
ad218b1
Compare
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 13, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
ad218b1 to
f564272
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 13, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
f564272 to
6269798
Compare
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 13, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
6269798 to
ff53120
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 15, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
ff53120 to
e497205
Compare
sirreal
approved these changes
Jul 16, 2025
Member
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
This is a nice improvement to the test clarity and the tag processor uses is likely more reliable.
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 18, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
e497205 to
17b32b5
Compare
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jul 18, 2025
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
17b32b5 to
a51e218
Compare
Member
Author
|
@github-actions: You are older than two weeks, therefore you have been deemed obsolete. Closing your bot. |
dmsnell
force-pushed
the
html-api/tests-filter-oembed
branch
from
a51e218 to
5c059e1
Compare
pento
pushed a commit
that referenced
this pull request
Oct 19, 2025
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces the use of PCRE matches in oEmbed filtering tests with semantic assertions via the HTML API and `assertEqualHTML()`. Developed in #9259 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 git-svn-id: https://develop.svn.wordpress.org/trunk@60972 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 19, 2025
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces the use of PCRE matches in oEmbed filtering tests with semantic assertions via the HTML API and `assertEqualHTML()`. Developed in WordPress/wordpress-develop#9259 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 Built from https://develop.svn.wordpress.org/trunk@60972 git-svn-id: http://core.svn.wordpress.org/trunk@60308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 19, 2025
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces the use of PCRE matches in oEmbed filtering tests with semantic assertions via the HTML API and `assertEqualHTML()`. Developed in WordPress/wordpress-develop#9259 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 Built from https://develop.svn.wordpress.org/trunk@60972 git-svn-id: https://core.svn.wordpress.org/trunk@60308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63694
Prep work for #9248.