#63678 Warn when a user has reached 'max_questions' mysql parameter #9223
Conversation
|
Hi @Meuh-42! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @fabien.bagard@ovhcloud.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Meuh-42
force-pushed
the
63678-fix-max_question
branch
2 times, most recently
from
99960ac to
e2d0541
Compare
|
WordPress redirect to wp-admin/install.php when a user is rate limited in MySQL. What are the rate limit parameters in MySQL ?A MySQL user can be created with a set of parameters to limit resources consumption:
https://dev.mysql.com/doc/refman/8.4/en/user-resources.html Setting these values may help protect the database server under heavy load, help mitigate How to reproduce ?
Once the number of query per hour for the user has been reduced (or ExpectationsAs this is a documented return code from MySQL, WordPress should display the correct error instead of redirecting to the installation page. Also, as we are hitting a rate-limiting value, we should not try to retry queries (thus making it harder to go below the limited value) but die on-spot.
|
src/wp-includes/class-wpdb.php
Outdated
| // User has reached 'max_questions' stop retrying | ||
| if ( 1226 === $mysql_errno ) { | ||
| $message = '<h1>' . __( 'Cannot connect to database' ) . "</h1>\n"; | ||
| $message .= '<p>' . sprintf( $this->last_error ); |
There was a problem hiding this comment.
Should this error include some kind of non-technical message, followed by the technical error message?
The average website visitor won't understand this message, but it will be helpful to site owners for debugging/support purposes.
There was a problem hiding this comment.
What about something like the following ?
There was a problem hiding this comment.
Yeah a clearer title and paragraph before the error message makes sense.
The paragraph before the error message could say "The database server could be connected to (which means your username and password is okay) but the query could not be performed.". That keeps it pretty close to the database selection error message.
For the last line, let's reuse this existing string too.
There was a problem hiding this comment.
I wanted to emphasis on the fact that all connection parameters are correct (even database name / connection port)
Same for last sentence, I tried to stay as close as possible to the existing messages to help translators, while being a bit more specific to this particular error message.
But your comments works pretty well as well.
I'm updating my PR
Meuh-42
force-pushed
the
63678-fix-max_question
branch
2 times, most recently
from
eb6f8ad to
41035a0
Compare
Meuh-42
force-pushed
the
63678-fix-max_question
branch
from
41035a0 to
380fe97
Compare
3 participants
Wordpress redirect to wp-admin/install.php when a user is rate limited in mysql,
instead of catching and displaying a valid error message
Trac ticket: https://core.trac.wordpress.org/ticket/63678
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.