Toolbar: Truncate long display name to prevent layout issues#9177
Toolbar: Truncate long display name to prevent layout issues#9177BugReportOnWeb wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
Hi @BugReportOnWeb! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
src/wp-includes/admin-bar.php
Outdated
| function wp_admin_bar_my_account_item( $wp_admin_bar ) { | ||
| $user_id = get_current_user_id(); | ||
| $current_user = wp_get_current_user(); | ||
| $display_name = mb_strimwidth( $current_user->display_name, 0, 40, '...' ); |
There was a problem hiding this comment.
The admin toolbar already uses wp_html_excerpt() to trim the Site Title (on the top level) to the first 40 characters.
| $display_name = mb_strimwidth( $current_user->display_name, 0, 40, '...' ); | |
| $display_name = wp_html_excerpt( $current_user->display_name, 40, '…' ); |
src/wp-includes/admin-bar.php
Outdated
| function wp_admin_bar_my_account_menu( $wp_admin_bar ) { | ||
| $user_id = get_current_user_id(); | ||
| $current_user = wp_get_current_user(); | ||
| $display_name = mb_strimwidth( $current_user->display_name, 0, 40, '...' ); |
There was a problem hiding this comment.
(this also could use wp_html_excerpt())
2 participants
Long user display names can cause the admin bar and user info dropdown layout to break, especially on smaller screens. This PR fixes the issue by truncating the display name to 40 characters in the backend before rendering, ensuring the layout remains stable and consistent.
Trac ticket: https://core.trac.wordpress.org/ticket/63607
Before
After