Skip to content

HTTP API: Improve error message to include the blocked URL #9169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SainathPoojary wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

HTTP API: Improve error message to include the blocked URL #9169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04b234
HTTP API: Improve error message to include the blocked URL and enhanc…
SainathPoojary Jul 1, 2025
536c1ee
Merge branch 'trunk' into feat/http-api
audrasjb Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/wp-includes/class-wp-http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ public function request( $url, $args = array() ) {
}

if ( $this->block_request( $url ) ) {
$response = new WP_Error( 'http_request_not_executed', __( 'User has blocked requests through HTTP.' ) );
/* translators: %s: URL to which the HTTP request was blocked. */
$response = new WP_Error( 'http_request_not_executed', sprintf( __( 'User has blocked requests through HTTP to the URL: %s.' ), $url ) );
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question: does exposing the full URL introduce any security concerns? I’m not aware of any specific issues, but it came to mind during the review.

cc: @johnbillion

Copy link
Copy Markdown
Member

@johnbillion johnbillion Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially an edge case concern if the URL contains a sensitive query parameter and the failure message gets logged somewhere, but I think the benefit outweighs this concern.

/** This action is documented in wp-includes/class-wp-http.php */
do_action( 'http_api_debug', $response, 'response', 'WpOrg\Requests\Requests', $parsed_args, $url );
return $response;
Expand Down
Loading