Skip to content

Fix setting transient where saving the timestamp in the database failed. - #910

Open
menno-ll wants to merge 12 commits into
WordPress:trunkfrom
menno-ll:fix/transient_missing_expiration_return_false
Open

menno-ll wants to merge 12 commits into
WordPress:trunkfrom
menno-ll:fix/transient_missing_expiration_return_false

Conversation

@menno-ll

Copy link
Copy Markdown

When getting an existing transient that should have a timeout, but in reality it has not, delete the existing transient and return false.

Trac ticket: https://core.trac.wordpress.org/ticket/52345


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Hi @menno-ll! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Comment thread tests/phpunit/tests/option/transient.php Outdated
@menno-ll
menno-ll changed the base branch from master to trunk June 2, 2022 10:27
@menno-ll menno-ll changed the title Fix getting transient with no timeout Fix setting transient where saving the timestamp in the database failed. Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants