Twenty Twenty: fix "Older Posts" label for archive pages with respect to order#9082
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
This looks good.
In default (descending) order, the navigation appears the same as it did before the patch. The screenshots show the theme's :focus underline and Firefox's :focus-visible outline for the first link in page navigation (DOM order), and I checked English and French.
With ?order=ASC, the labels switch accordingly.
On smaller screens, it still hides "posts":
Full-page screenshots show three posts, with different published dates (matching the chapter number to the day of the month).
- Before patch, default order
- Before patch, ascending order
- With patch, default order
- With patch, ascending order
A diff shows the text changes for the ASC page, before and after applying the patch, within the markup:
<nav class="navigation pagination" aria-label="Posts pagination">
<h2 class="screen-reader-text">Posts pagination</h2>
- <div class="nav-links"><a class="prev page-numbers" href="http://localhost/svn/src/tag/alice/?order=ASC"><span aria-hidden="true">←</span> <span class="nav-prev-text">Newer <span class="nav-short">Posts</span></span></a>
+ <div class="nav-links"><a class="prev page-numbers" href="http://localhost/svn/src/tag/alice/?order=ASC"><span aria-hidden="true">←</span> <span class="nav-prev-text">Older <span class="nav-short">Posts</span></span></a>
<a class="page-numbers" href="http://localhost/svn/src/tag/alice/?order=ASC">1</a>
<span aria-current="page" class="page-numbers current">2</span>
<a class="page-numbers" href="http://localhost/svn/src/tag/alice/page/3/?order=ASC">3</a>
<a class="page-numbers" href="http://localhost/svn/src/tag/alice/page/4/?order=ASC">4</a>
-<a class="next page-numbers" href="http://localhost/svn/src/tag/alice/page/3/?order=ASC"><span class="nav-next-text">Older <span class="nav-short">Posts</span></span> <span aria-hidden="true">→</span></a></div>
+<a class="next page-numbers" href="http://localhost/svn/src/tag/alice/page/3/?order=ASC"><span class="nav-next-text">Newer <span class="nav-short">Posts</span></span> <span aria-hidden="true">→</span></a></div>
</nav>
|
5 participants
Similar to PR
Fixes the issue: "Older Entries" and "Newer Entries" links are wrong when entries displayed in ascending order for the Twenty Twenty theme by adding dynamic labels according to the order query var (DESC or ASC). More info in the trac ticket.
Trac ticket: https://core.trac.wordpress.org/ticket/10219
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.