Post: Fix wp_list_pages() to correctly honor exclude with depth parameter#9045
Post: Fix wp_list_pages() to correctly honor exclude with depth parameter#9045SainathPoojary wants to merge 5 commits intoWordPress:trunkfrom
wp_list_pages() to correctly honor exclude with depth parameter#9045Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Fixes unexpected behavior when using wp_list_pages() with both depth and exclude parameters.
Previously, excluded parent pages would also exclude their children if depth > 0, making exclude behave like exclude_tree. This change updates the walker logic to ensure orphaned children of excluded parents are still displayed when depth is limited, consistent with how exclude works without depth.
A follow-up commit will add unit test coverage for this behavior.
Trac ticket: #27326
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.