Skip to content

Fix: Removed global variable $current_screen used in wp_enqueue_registered_block_scripts_and_styles (Trac #63413)#8784

Closed
umeshnevase wants to merge 1 commit intoWordPress:trunkfrom
umeshnevase:fix/removed-unused-global-variable-current_screen
Closed

Fix: Removed global variable $current_screen used in wp_enqueue_registered_block_scripts_and_styles (Trac #63413)#8784
umeshnevase wants to merge 1 commit intoWordPress:trunkfrom
umeshnevase:fix/removed-unused-global-variable-current_screen

Conversation

@umeshnevase
Copy link
Copy Markdown

@umeshnevase umeshnevase commented May 8, 2025

  • There is unsed global variable in code. We should remove it for extra overhead for code parsing and Opcode Compilation.
  • I've removed that global variable and from function data in this PR.
  • The global is variable not used anywhere in function and not required.

Trac ticket: https://core.trac.wordpress.org/ticket/63413#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…tered_block_scripts_and_styles (Trac #63413)
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props umeshnevase, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27
Copy link
Copy Markdown
Member

Thanks for the PR, it looks good to me. Let’s wait for the unit tests to pass.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60230
GitHub commit: 02d07b1

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants