Skip to content

Fix: Restore Local Request Handling for SSL Verification for https_local_ssl_verify filter#8751

Closed
Debarghya-Banerjee wants to merge 2 commits intoWordPress:trunkfrom
Debarghya-Banerjee:fix/51767-improve-broken-logic-for-https_local_ssl_verify
Closed

Fix: Restore Local Request Handling for SSL Verification for https_local_ssl_verify filter#8751
Debarghya-Banerjee wants to merge 2 commits intoWordPress:trunkfrom
Debarghya-Banerjee:fix/51767-improve-broken-logic-for-https_local_ssl_verify

Conversation

@Debarghya-Banerjee
Copy link
Copy Markdown

Trac Ticket: Core-51767

Issue

In WordPress 4.6, the $args['local'] element was removed from HTTP API requests, which caused the https_local_ssl_verify filter to malfunction.

Solution

This update restores the expected behaviour by checking if a request is local using:

  • The REMOTE_ADDR (127.0.0.1, ::1).

  • The HTTP_HOST (localhost, 127.0.0.1).

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion
Copy link
Copy Markdown
Member

This has nothing to do with the current request, only the HTTP API request being performed.

@johnbillion johnbillion closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants