Editor: Fix sticky posts on top of every page in Query Loop Block.#8750
Editor: Fix sticky posts on top of every page in Query Loop Block.#8750karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
Conversation
- Adds 'paged' var to query if 'perpage' is set. - Update unit test to include the 'paged' var.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 participant
Trac ticket: https://core.trac.wordpress.org/ticket/63365
Gutenberg issue: WordPress/gutenberg#69867
This PR adds the
pagedvariable when building the query for the Query Loop block, which limits sticky posts to the first page. It also updates the unit tests to include thepagedvariable when theperPageattribute is set. This behaviour also aligns with the REST API behaviour in 6.8.1 ifignore_stickyis set tofalse.It does not address other known issues with sticky posts, such as having more posts than the perPage value on the first page.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.