Fixed skip array_map() in get_terms() if object_ids is not set#8668
Fixed skip array_map() in get_terms() if object_ids is not set#8668dilipbheda wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| } | ||
|
|
||
| if ( '' === $args['object_ids'] ) { | ||
| if ( empty( $args['object_ids'] ) ) { |
There was a problem hiding this comment.
This makes sense as it is consistent with:
There was a problem hiding this comment.
See https://core.trac.wordpress.org/ticket/63256#comment:7
| if ( empty( $args['object_ids'] ) ) { | |
| if ( empty( $args['object_ids'] ) && ! is_numeric( $args['object_ids'] ) ) { |
| } | ||
|
|
||
| if ( '' === $args['object_ids'] ) { | ||
| if ( empty( $args['object_ids'] ) ) { |
There was a problem hiding this comment.
See https://core.trac.wordpress.org/ticket/63256#comment:7
| if ( empty( $args['object_ids'] ) ) { | |
| if ( empty( $args['object_ids'] ) && ! is_numeric( $args['object_ids'] ) ) { |
|
Let's also include a unit test for this change. |
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/63256