Skip to content

Users: Handle errors when display name exceeds 250 characters.#8655

Open
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
karthikeya-io:fix/handle-large-display-name
Open

Users: Handle errors when display name exceeds 250 characters.#8655
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
karthikeya-io:fix/handle-large-display-name

Conversation

@karthikeya-io
Copy link
Copy Markdown

@karthikeya-io karthikeya-io commented Apr 4, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/36405

The display name is created by combining the first name and last name. Although there is no limit on the length of the first name or last name, the display name has a limit of 250 characters. If the display name exceeds 250 characters, it causes an unhandled error and does not show a valid message to the user. This PR adds a condition to check if the display name exceeds 250 characters and returns an appropriate error message.

Before After
display-name-before.mov
display-name-after.mov

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@karthikeya-io karthikeya-io marked this pull request as ready for review April 7, 2025 07:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props karthikeya01.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant