Skip to content

Fix: Update wp_verify_fast_hash to use wp_check_password for backward compatibility#8624

Closed
Debarghya-Banerjee wants to merge 1 commit intoWordPress:trunkfrom
Debarghya-Banerjee:fix/63203-wp_verify_fast_hash
Closed

Fix: Update wp_verify_fast_hash to use wp_check_password for backward compatibility#8624
Debarghya-Banerjee wants to merge 1 commit intoWordPress:trunkfrom
Debarghya-Banerjee:fix/63203-wp_verify_fast_hash

Conversation

@Debarghya-Banerjee
Copy link
Copy Markdown

Trac Ticket: Core-63203

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Copy Markdown
Contributor

@Debarghya-Banerjee Thank you for creating the pull request.

Unfortunately, this isn't the approach that will be needed. wp_verify_fash_hash() will need to remain unchanged, the functionality that will need a change is for application passwords.

In WP_Application_Passwords::create_new_application_password() the variable $hashed_password will need to be modified to use wp_hash_password()

$hashed_password = self::hash_password( $new_password );

In wp_authenticate_application_password() the password check will need to be modified to use wp_check_password()

if ( ! WP_Application_Passwords::check_password( $password, $item['password'] ) ) {

With those changes, it should be possible to remove the methods introduced in WP 6.8 from WP_Application_Passwords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants