Fix: Handle presence of ; in CSS value while sanitizing inline styles#8583
Fix: Handle presence of ; in CSS value while sanitizing inline styles#8583karthikeya-io wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
Hi @karthikeya-io! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $allowed_protocols = wp_allowed_protocols(); | ||
|
|
||
| $css_array = explode( ';', trim( $css ) ); | ||
| $css_array = preg_split( '/;(?![^()]*\)|[^"\']*["\'][^"\']*$)/', trim( $css ) ); |
There was a problem hiding this comment.
Nice to have unit tests coverage for the changes.
There was a problem hiding this comment.
Thanks @mukeshpanchal27 for reviewing the PR. 🙇
Added the test cases for the changes. Please take a look.
2 participants
The PR handles the case when a semi-colon(;) is present in CSS value while splitting the styles while sanitizing inline-styles.
Currently the CSS is split with
$css_array = explode( ';', trim( $css ) );which results in unexpected sanitized inline-style if a CSS value has a;in it.The PR refactors CSS string parsing to handle edge cases with semicolons inside functions or quoted strings.
Trac ticket: https://core.trac.wordpress.org/ticket/63162
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.