Skip to content

Possible bug (not strict) use of preg_split in formatting.php#8553

Open
umeshsinghin wants to merge 2 commits intoWordPress:trunkfrom
umeshsinghin:63131-preg_split
Open

Possible bug (not strict) use of preg_split in formatting.php#8553
umeshsinghin wants to merge 2 commits intoWordPress:trunkfrom
umeshsinghin:63131-preg_split

Conversation

@umeshsinghin
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props umeshsinghin, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@audrasjb
Copy link
Copy Markdown
Contributor

Thanks for the PR, but instead of hiding the error using @preg_split, we should rather explore why there is a warning at the first place and fix it if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants