Skip to content

Prevent emojis in plugin titles from appearing before text#8534

Closed
Infinite-Null wants to merge 2 commits intoWordPress:trunkfrom
Infinite-Null:fix/plugin-title-emoji-display
Closed

Prevent emojis in plugin titles from appearing before text#8534
Infinite-Null wants to merge 2 commits intoWordPress:trunkfrom
Infinite-Null:fix/plugin-title-emoji-display

Conversation

@Infinite-Null
Copy link
Copy Markdown

@Infinite-Null Infinite-Null commented Mar 18, 2025

Trac ticket: #63120

What

When a plugin title contains an emoji (e.g., myplugin❤️wordpress), the emoji incorrectly appears before the text on the WordPress plugins admin page, showing as ❤️mypluginwordpress.

Screenshot:

Before Patch:

wp-admin/plugins.php:

image

After Patch:

wp-admin/plugins.php:

image

Plugin Update Page:

image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, ant1busted, sandeepdahiya.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ant1sg
Copy link
Copy Markdown

ant1sg commented May 18, 2025

Hi, I did try this PR in playground and it worked, but I tried with a classic playgournd (not including the PR) it also worked.
Are you sure this does not come from something else in your install?
image

@Infinite-Null
Copy link
Copy Markdown
Author

Infinite-Null commented May 19, 2025

Hi @ant1sg,
Thank you for testing the PR!

In your case, it seems that the system fonts are being used for rendering emojis. WordPress includes a fallback mechanism where, if the emoji feature detection test fails, emojis are loaded from https://s.w.org/images/core/emoji/15.0.3/svg/.

However, since your browser successfully uses system emojis, this fallback behavior isn’t triggered hence, the issue doesn’t occur on your end.

@ant1sg
Copy link
Copy Markdown

ant1sg commented May 19, 2025

Hello @Infinite-Null yes I just noticed all the comments on Trac, I had not seen them. Sorry about that. I'll try to rerun the test properly

@iamsandeepdahiya
Copy link
Copy Markdown

I tried and this patch submitted and it is working perfectly. Thanks.

@Infinite-Null
Copy link
Copy Markdown
Author

Infinite-Null commented Sep 9, 2025

Closing as merged 60680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants