Add caching to count_many_users_posts() #8444
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Now that r60697 has been merged, this PR needs to be updated.
| $cache_key = 'count_many_users_posts:' . md5( $query ) . ':' . $last_changed; | ||
| $counts = wp_cache_get( $cache_key, 'post-queries' ); |
There was a problem hiding this comment.
| $cache_key = 'count_many_users_posts:' . md5( $query ) . ':' . $last_changed; | |
| $counts = wp_cache_get( $cache_key, 'post-queries' ); | |
| $cache_key = 'count_many_users_posts:' . md5( $query ); | |
| $counts = wp_cache_get_salted( $cache_key, 'post-queries', $last_changed ); |
| $count = array_fill_keys( $users, 0 ); | ||
| foreach ( $result as $row ) { | ||
| $count[ $row[0] ] = $row[1]; | ||
| wp_cache_set( $cache_key, $counts, 'post-queries' ); |
There was a problem hiding this comment.
| wp_cache_set( $cache_key, $counts, 'post-queries' ); | |
| wp_cache_set_salted( $cache_key, $counts, 'post-queries', $last_changed ); |
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/63045
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.