Skip to content

Conversation

@juhi123
Copy link

@juhi123 juhi123 commented Jan 7, 2025

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props juhise, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juhi123 juhi123 changed the title Add Playwright E2E test to add time zone test Add Playwright E2E test to change time zone test Jan 7, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@aaronjorbin
Copy link
Member

One change that I would like to see is that the restoring of the default value should be moved into an afterAll action so that if the assertion fails for some reason, the default value is still restored.

@juhi123
Copy link
Author

juhi123 commented Jan 16, 2025

Hey @aaronjorbin
Thanks for the review. I agree that makes sense, somehow I missed this. I have added now in afterEach, please have a look.
afterAll can't be used as page fixtures are created per test basis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants