FIX: Add REST API filters to the Global Styles Revisions controller.#8062
FIX: Add REST API filters to the Global Styles Revisions controller.#8062patil-vipul wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Adds filter to modify query arguments for global styles revisions before the query is run.
Adds filter to modify global styles revision data before sending to API response.
|
Hi @patil-vipul! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@Mamaduka Can you take a look at this PR 🙇 |
|
@anton-vlasenko Can you look at this PR. |
There was a problem hiding this comment.
This looks good to me.
However, since WP_REST_Global_Styles_Revisions_Controller has been updated to better support HEAD requests, I believe this PR should be updated accordingly to reflect those changes.
It would also be great to include some PHPUnit tests.
| * | ||
| * Allows modification of the global styles revision right before it is returned. | ||
| * | ||
| * @since 6.7.2 |
There was a problem hiding this comment.
| * @since 6.7.2 | |
| * @since 6.9.0 |
3 participants
Summary
This PR adds two standard WordPress REST API filters to the Global Styles Revisions controller:
rest_global_styles_revision_queryandrest_prepare_global_styles_revision.Currently, WP_REST_Global_Styles_Revisions_Controller lacks the standard WordPress REST filters, likely an oversight since other revision controllers include them.
Changes Proposed
rest_global_styles_revision_queryfilter for query modificationrest_prepare_global_styles_revisionfilter for response data modificationTrac ticket: https://core.trac.wordpress.org/ticket/62742
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.