Used WP_Query in wp_get_post_autosave instead of raw query#7962
Used WP_Query in wp_get_post_autosave instead of raw query#7962narenin wants to merge 22 commits intoWordPress:trunkfrom
WP_Query in wp_get_post_autosave instead of raw query#7962Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Thanks for your patch!
It looks good at first glance. Just two things:
- While there is some test coverage for this function already via other tests, it would be good to add dedicated tests for this function. Of course they should all pass :)
- Let's remove all those inline comments. They don't provide any additional value.
|
Additional props to @im3dabasia who opened #7965 |
swissspidy
added
the
props-bot
github-actions
bot
removed
the
props-bot
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Requests some review that will fix tests.
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Overall looks solid to me. Left some nit-pick feedbacks.
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
|
@narenin take a look pending feedback #7962 (comment) from @spacedmonkey |
|
@spacedmonkey I have implemented suggestions, could you please take a look. |
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Sorry, final final things and I will commit.
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
|
Hi @spacedmonkey, Would we be eligible to receive the Testing badge once this PR is merged? I initially contributed to the tests in the PR, which was later merged into this PR. I was wondering if I might still be eligible for the badge. Nice work @narenin 💯 |
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
|
@spacedmonkey thanks for the feedbacks, I have implemented the suggestions could you please take the look. |
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Marked as approved, I am happy to commit. Do you mind taking a look @swissspidy @mukeshpanchal27 before I commit.
|
@im3dabasia See https://make.wordpress.org/test/handbook/test-team-profile-badges/ for that badge and its requirements and how to request it if you meet them. @spacedmonkey LGTM |
5 participants
Trac ticket: https://core.trac.wordpress.org/ticket/62658
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.