Fix category checkbox handler ID matching#7863
Fix category checkbox handler ID matching#7863ffffelix wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the patch, @ffffelix! I was also able to reproduce this issue by unchecking and re-checking "Uncategorized" (used this Playground link that generates the terms). To test the patch, the default Playground link works fine if you go through the repro set up steps. But try out this one that combines the repro test with the PR (takes longer to load in order to build the PR patch). These links will look kinda nasty in Trac, but I'll share a formal test report there. |
Co-authored-by: Andrew Ozz <743931+azaozz@users.noreply.github.com>
|
Thanks for the PR! This was merged in r59454. |
Fixes category checkboxes in v6.7.1.
This change makes matching the desired tag ID to its checkbox elements more strict.
Example: when selecting a category with an ID of 1, the jQuery selector would also match the checkboxes for any category with an ID starting 1 (e.g. 10, 110, 1043).
The checkbox IDs are output via
wp_unique_prefixed_idso should always have a trailingslashdash after the ID.Trac ticket: https://core.trac.wordpress.org/ticket/62504
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.