Skip to content

Refactor wp_registration_url() to accept an optional redirect parameter#7725

Open
nirajgiriXD wants to merge 4 commits intoWordPress:trunkfrom
nirajgiriXD:feat/add-redirect-argument
Open

Refactor wp_registration_url() to accept an optional redirect parameter#7725
nirajgiriXD wants to merge 4 commits intoWordPress:trunkfrom
nirajgiriXD:feat/add-redirect-argument

Conversation

@nirajgiriXD
Copy link
Copy Markdown

Description

This PR adds an optional $redirect parameter to wp_registration_url(), enabling redirection after registration, similar to other WordPress URL functions. If a redirect URL is provided, it’s added as a redirect_to query argument.

Changes Made

Added $redirect Parameter:

  • Allows specifying a redirect URL for post-registration navigation.
  • Checks if $redirect is provided, and if so, adds it as a redirect_to query argument to the base registration URL.
  • The function now filters the updated $register_url and includes the $redirect parameter in the filter hook, ensuring custom modifications to the registration URL also have access to this parameter.

Testing Instruction

  • Check wp_registration_url() with and without a redirect parameter.
  • Verify that the generated URL correctly includes the redirect_to parameter when specified.

Trac ticket: https://core.trac.wordpress.org/ticket/27632

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nirajgirixd, apermo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown

@apermo apermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to rename $redirect to $redirect_to as this will be consistent with the url parameter.
And the change should be documented with a new @since in the phpdoc header.

@nirajgiriXD nirajgiriXD requested a review from apermo November 7, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants