Fix: Misleading Message When Accessing Admin Menu Page by nirajgiriXD · Pull Request #7613 · WordPress/wordpress-develop

nirajgiriXD · 2024-10-22T13:32:03Z

Description

This PR addresses the issue where the misleading message You do not have sufficient permissions to access this page. was displayed when attempting to access an admin page that doesn't exist. Instead of suggesting a permissions problem, the fix ensures that users are now shown a clearer message: The requested page does not exist. This provides a more accurate and user-friendly explanation when the page is missing or unavailable.

Screenshot

Testing Instructions

Install a plugin that includes a settings page.
Navigate to the plugin's settings page and copy the URL.
Go to the plugins page and deactivate the plugin you just installed.
Paste the copied URL of the plugin's settings page into the browser's address bar and press Enter.
You should now see the message The requested page does not exist. instead of You do not have sufficient permissions to access this page.

Trac ticket: https://core.trac.wordpress.org/ticket/14060

github-actions · 2024-10-22T13:32:19Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nirajgiri9860@googlemail.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nirajgirixd, apermo, mindctrl, noruzzaman, westonruter, shailu25, huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-10-22T13:52:11Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

src/wp-admin/includes/plugin.php

Co-authored-by: Christoph Daum <c.daum@me.com>

apermo

Looks good to me

src/wp-admin/includes/menu.php

mindctrl · 2025-07-23T18:49:46Z

src/wp-admin/includes/plugin.php

+ * @global string $plugin_page
+ * @global array  $_registered_pages
+ */
+function admin_page_exists() {


Some phpunit tests for this function would be nice.

mindctrl · 2025-07-23T18:51:28Z

@nirajgiriXD I left some feedback for consideration. Also, could you bring this up to date with the latest trunk branch?

Co-authored-by: John Parris <public@johnparris.com>

nirajgiriXD · 2025-07-24T04:25:17Z

@mindctrl Thanks for the feedback! I've implemented the suggested changes and updated the branch with the latest from trunk.

mindctrl

Needs unit tests. Needs discussion about introducing a new action, if it's desired, and what its name should be.

src/wp-admin/includes/menu.php

src/wp-admin/includes/plugin.php

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

src/wp-admin/includes/menu.php

src/wp-admin/includes/plugin.php

Co-authored-by: Shail Mehta <shailmehta25@gmail.com>

Co-authored-by: Huzaifa Al Mesbah <huzaifah4m@gmail.com>

Co-authored-by: Weston Ruter <westonruter@gmail.com>

fix: misleading message when accessing admin menu page

13ec380

nirajgiriXD added 2 commits October 22, 2024 19:04

fix phpcs: remove empty line

c169041

fix phpcs: add space

b55ed49

apermo reviewed Oct 25, 2024

View reviewed changes

src/wp-admin/includes/plugin.php Show resolved Hide resolved

Update comment

061fc20

Co-authored-by: Christoph Daum <c.daum@me.com>

nirajgiriXD requested a review from apermo October 25, 2024 12:22

apermo approved these changes Oct 25, 2024

View reviewed changes

mindctrl suggested changes Jul 23, 2025

View reviewed changes

nirajgiriXD and others added 3 commits July 24, 2025 09:08

Update src/wp-admin/includes/menu.php

261dbd4

Co-authored-by: John Parris <public@johnparris.com>

Update src/wp-admin/includes/menu.php

dd3aca5

Co-authored-by: John Parris <public@johnparris.com>

Merge branch 'trunk' into fix/misleading-permissions-message

cfdb1d4

mindctrl suggested changes Nov 3, 2025

View reviewed changes

noruzzamans reviewed Dec 1, 2025

View reviewed changes

westonruter reviewed Dec 1, 2025

View reviewed changes

src/wp-admin/includes/plugin.php Outdated Show resolved Hide resolved

nirajgiriXD and others added 6 commits December 2, 2025 09:04

Update src/wp-admin/includes/menu.php

c3c6ba5

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

Update src/wp-admin/includes/plugin.php

d03c40e

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

Update src/wp-admin/includes/plugin.php

9a7a02f

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

Update src/wp-admin/includes/plugin.php

24606e8

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

Update src/wp-admin/includes/plugin.php

23fd2b8

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Update src/wp-admin/includes/plugin.php

2f2a4a4

Co-authored-by: Noruzzaman <noruzzamanrubel@gmail.com>

shail-mehta reviewed Feb 16, 2026

View reviewed changes

src/wp-admin/includes/menu.php Outdated Show resolved Hide resolved

huzaifaalmesbah reviewed Feb 16, 2026

View reviewed changes

src/wp-admin/includes/plugin.php Outdated Show resolved Hide resolved

westonruter reviewed Feb 16, 2026

View reviewed changes

src/wp-admin/includes/plugin.php Outdated Show resolved Hide resolved

westonruter reviewed Feb 16, 2026

View reviewed changes

src/wp-admin/includes/plugin.php Outdated Show resolved Hide resolved

nirajgiriXD and others added 2 commits February 17, 2026 08:48

Update src/wp-admin/includes/menu.php

a95d739

Co-authored-by: Shail Mehta <shailmehta25@gmail.com>

Update src/wp-admin/includes/plugin.php

ad8e1df

Co-authored-by: Huzaifa Al Mesbah <huzaifah4m@gmail.com>

nirajgiriXD and others added 3 commits February 17, 2026 08:50

Update src/wp-admin/includes/plugin.php

e5e363d

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Update src/wp-admin/includes/plugin.php

c71ac8d

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Merge branch 'trunk' into fix/misleading-permissions-message

c03dfd5

nirajgiriXD requested a review from westonruter February 18, 2026 02:54

Conversation

nirajgiriXD commented Oct 22, 2024

Description

Screenshot

Testing Instructions

Trac ticket: https://core.trac.wordpress.org/ticket/14060

Uh oh!

github-actions bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions bot commented Oct 22, 2024

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

apermo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mindctrl Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

mindctrl commented Jul 23, 2025

Uh oh!

nirajgiriXD commented Jul 24, 2025

Uh oh!

mindctrl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Oct 22, 2024 •

edited

Loading