Fix possible PHP warning in rss_enclosure()#7557
Fix possible PHP warning in rss_enclosure()#7557Rahmon wants to merge 15 commits intoWordPress:trunkfrom
rss_enclosure()#7557Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
I've added a few notes inline.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
|
Thanks for your review @peterwilsoncc 🙏 |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Added a couple more notes re naming things.
Are you able to run git rm tests/phpunit/tests/feed/feed.php tests/phpunit/tests/feed/rssEnclosure.php too (please validate command, untested).
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Sure. ✔️ |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thank you! This looks good to me.
This PR checks the size of
enclosuremeta field inrss_enclosure()function and add some tests to this function.Trac ticket: https://core.trac.wordpress.org/ticket/58798
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.