Skip to content

61837: REST API: Password should only be considered by permissions check when in query params#7367

Closed
kadamwhite wants to merge 4 commits intoWordPress:trunkfrom
kadamwhite:61837-get-item-permissions-while-updating-password
Closed

61837: REST API: Password should only be considered by permissions check when in query params#7367
kadamwhite wants to merge 4 commits intoWordPress:trunkfrom
kadamwhite:61837-get-item-permissions-while-updating-password

Conversation

@kadamwhite
Copy link
Copy Markdown
Contributor

@kadamwhite kadamwhite commented Sep 17, 2024 •
edited
Loading

Trac ticket: https://core.trac.wordpress.org/ticket/61837

request[password] is checked when calculating item permissions, and this check does not restrict itself to looking at the password provided as a query parameter.

Adding unit tests for failing situation described in ticket, then will update with a merged patch.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kadamwhite, timothyblynjacobs.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@kadamwhite kadamwhite force-pushed the 61837-get-item-permissions-while-updating-password branch from e9a644c to f5f01dc Compare September 17, 2024 19:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

TimothyBJacobs
TimothyBJacobs reviewed Sep 17, 2024
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Sep 17, 2024
View reviewed changes
TimothyBJacobs
TimothyBJacobs approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TimothyBJacobs TimothyBJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@kadamwhite
Copy link
Copy Markdown
Contributor Author

kadamwhite commented Sep 17, 2024

Merged in 15b7d2a

@kadamwhite kadamwhite closed this Sep 17, 2024
@kadamwhite kadamwhite deleted the 61837-get-item-permissions-while-updating-password branch September 17, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadamwhite @TimothyBJacobs