Skip to content

Media php strict comparison#7309

Closed
deepakrohillas wants to merge 27 commits intoWordPress:trunkfrom
deepakrohillas:media_php_strict_comparison
Closed

Media php strict comparison#7309
deepakrohillas wants to merge 27 commits intoWordPress:trunkfrom
deepakrohillas:media_php_strict_comparison

Conversation

@deepakrohillas
Copy link
Copy Markdown

@deepakrohillas deepakrohillas commented Sep 8, 2024

… add_action()

`error.message` LIKE 'Uncaught exception 'Error' with message 'Call to undefined function add_action()' in /var/www/wp-content/plugins/hello.php:69%' AND `error.class` = 'Error' AND transactionUiName = '/wp-content/plugins/hello.php'

'request_uri': '/wp-content/plugins/hello.php'
…dolly_uncaught_exception

Fix Uncaught exception Error with message 'Call to undefined function…
Plugin URI http to https change
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2024

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props deepakrohilla, mukesh27, aristath, dingguodong.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@DingGuodong
Copy link
Copy Markdown

DingGuodong commented Sep 8, 2024

Oh, it's very confusing. I wander that why there is only one change in the file but there are 27 commits? @deepakrohillas deepakrohilla Could you explain it for me? Thank you !

@mukeshpanchal27
Copy link
Copy Markdown
Member

@DingGuodong, this is due to code committed in the branch and some upstream merges. Only the new changes need to be reviewed. When you have a moment, please review them and share your feedback here.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! In quick review LGTM.

@DingGuodong
Copy link
Copy Markdown

DingGuodong commented Sep 9, 2024

@DingGuodong, this is due to code committed in the branch and some upstream merges. Only the new changes need to be reviewed. When you have a moment, please review them and share your feedback here.

Thanks for your reply. So, I think it is due to the committer pull some commits from another branch before request this PR.
It is too hard for the developer request one PR if in this way. Because of he need to merge many commits before request the PR. I hope this is not a common case. :)

@SergeyBiryukov
Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r59497.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants