Skip to content

Conversation

@mi5t4n
Copy link

@mi5t4n mi5t4n commented Aug 8, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61844


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mi5t4n, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt
Copy link

I think this is ready.

Links rarely are focusable in the editor, so I do not think it is worth setting the outline color too. Changing the text color and removing the bottom border should be enough for those cases (such as clicking on a disabled link within the Latest Posts block).

Front:

link is dark text with bottom border, hover and focus styles are medium gray with no border, focus outline is light gray

Editors before patch:

hover text in the iframe and the focus outline can be blue; otherwise, links are all dark with bottom border

Editors with patch:

link is dark text with bottom border, hover and focus styles are medium gray with no border, focus outline is blue

@mi5t4n
Copy link
Author

mi5t4n commented Mar 3, 2025

Commited with changeset r58910

@mi5t4n mi5t4n closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants