Improve Accessibility of Comment Reply Links#7138
Improve Accessibility of Comment Reply Links#7138snehapatil2001 wants to merge 5 commits intoWordPress:trunkfrom
Conversation
…isible text and aria-label.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sabernhardt
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I gave a few suggestions.
…n and Twenty Seventeen Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
|
In r59181 |
This PR enhances the accessibility of comment reply links by synchronizing the visible text and the
aria-labelattribute. This resolves issues where elements with visible text labels did not have matching accessible names.Changes
use_reply_to_textparameter to the$argsarray with a default value offalse.reply_to_textanduse_reply_to_text.reply_to_textas the visible text whenuse_reply_to_textistrue.aria-labelwhen it would be redundant (i.e., whenuse_reply_to_textistrue).Trac ticket: https://core.trac.wordpress.org/ticket/59965
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.