Skip to content

wp_kses & block parser being used on pre_term_name hook#6855

Closed
snehapatil2001 wants to merge 2 commits intoWordPress:trunkfrom
snehapatil2001:fix/issue-61455
Closed

wp_kses & block parser being used on pre_term_name hook#6855
snehapatil2001 wants to merge 2 commits intoWordPress:trunkfrom
snehapatil2001:fix/issue-61455

Conversation

@snehapatil2001
Copy link
Copy Markdown

@snehapatil2001 snehapatil2001 commented Jun 19, 2024

Changes Made

This PR enhances the KSES filtering mechanism in WordPress to improve handling of term names within content parsing. Specifically:

  • Code Changes: Updated wp_kses_hook and filter_block_content functions to include a context check (if ( current_filter() === 'pre_term_name' )) to bypass block content parsing for term names. This prevents term names from being mistakenly treated as block content during sanitization processes.

Purpose

  • The purpose of these changes is to enhance the accuracy and efficiency of content filtering in WordPress, specifically when dealing with term names. By ensuring that term names are not parsed as block content, we improve security and performance while maintaining robust sanitization practices across different content types.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props snehapatil02.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@snehapatil2001 snehapatil2001 deleted the fix/issue-61455 branch June 19, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant