Skip to content

Enhancement: Changing Site Admin Email Assumes Username and Who Took the Action#6789

Open
the-hercules wants to merge 1 commit intoWordPress:trunkfrom
the-hercules:fix/48879
Open

Enhancement: Changing Site Admin Email Assumes Username and Who Took the Action#6789
the-hercules wants to merge 1 commit intoWordPress:trunkfrom
the-hercules:fix/48879

Conversation

@the-hercules
Copy link
Copy Markdown

Trac Ticket : Ticket #48879

This PR addresses and resolves the confusion caused by the current email notification sent when the site admin email address is updated.
Issues Fixed:

  1. Incorrect Addressing: The email was previously addressed to the current user's username, causing confusion for the recipient.
  2. Misleading Language: The email stated “Howdy, ###USERNAME### ” which was misleading for recipients who did not perform the action.
    Changes Made:
  • The email is now addressed generically without using the current user's username. i.e “Howdy,”
  • The language has been updated to indicate that someone (specified by the username of the requester) has requested the email change, rather than implying the recipient performed the action.
    These changes aim to reduce confusion and prevent users from thinking the email is a phishing attempt.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@the-hercules the-hercules marked this pull request as ready for review June 12, 2024 08:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @aashish.sharma@rtcamp.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props madtownlems.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@MadtownLems
Copy link
Copy Markdown

Thanks for doing this!

This language feels a bit clunky to me:
"User ###USERNAME### with administrator capabilities recently requested"

Perhaps something more like:
"A site Administrator (###USERNAME###) recently requested"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants