Fix: Check for empty user_nicename in wp_insert_user#6775
Fix: Check for empty user_nicename in wp_insert_user#6775the-hercules wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @aashish.sharma@rtcamp.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @mukeshpanchal27, Can you review this PR. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks for the PR @the-hercules and for your testing @Rayhatron.
I took the liberty of merging in trunk to make sure the PR still applied correctly and the tests passed as expected.
This looks good for commit.
|
If possible add unit test coverage for changes. |
Fixes Ticket #57635
Check if 'user_nicename' is empty in the function 'wp_insert_user' after the 'sanitize_title' and filter 'pre_user_nicename'.