Fix return type in @phpdocs for rest_parse_data#6654
Fix return type in @phpdocs for rest_parse_data#6654lipemat wants to merge 1 commit intoWordPress:trunkfrom lipemat:patch-1
rest_parse_data#6654Conversation
The return type was `int` but it would return `false` if the date format passed is invalid.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Fix the return type for rest_parse_data. WordPress/wordpress-develop#6654
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Nice catch. Pre approve. Could you add unit test that cover that scenario?
|
Thanks for the PR! Merged in r58267. |
The return type was
intbut it would returnfalseif the date format passed is invalid.Trac ticket: https://core.trac.wordpress.org/ticket/60699