Skip to content

Fix return type in @phpdocs for rest_parse_data#6654

Closed
lipemat wants to merge 1 commit intoWordPress:trunkfrom
lipemat:patch-1
Closed

Fix return type in @phpdocs for rest_parse_data#6654
lipemat wants to merge 1 commit intoWordPress:trunkfrom
lipemat:patch-1

Conversation

@lipemat
Copy link
Copy Markdown

@lipemat lipemat commented May 27, 2024

The return type was int but it would return false if the date format passed is invalid.

Trac ticket: https://core.trac.wordpress.org/ticket/60699

The return type was `int` but it would return `false` if the date format passed is invalid.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mat-lipe.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

lipemat added a commit to lipemat/phpstan-wordpress that referenced this pull request May 27, 2024
Fix the return type for rest_parse_data.

WordPress/wordpress-develop#6654
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Pre approve. Could you add unit test that cover that scenario?

@SergeyBiryukov
Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r58267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants