Repository navigation
Expand performance tests setup - #6515
swissspidy wants to merge 37 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
That part doesn't seem to be working yet. Looks like stats are not reset between runs. |
|
@felixarntz @joemcgill This relates to WordPress/performance#1735 I previously opened this to test with multisite, but not sure how useful that is. Maybe we can just support it in the workflow for manual invoke but not actually run it for every commit/PR. Second, this now tests a single post URL too, but that adds a lot of noise, as it increases the number of combinations. We might want to clean up the summary a little bit or so. Example: https://github.com/WordPress/wordpress-develop/actions/runs/12373742576?pr=6515 Aside: The object cache stats still don't look correct and actually probably aren't useful, so I'll remove them. |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@swissspidy This looks awesome! I hope we can land this soon.
Just a few questions, and some suggestions for consolidating duplicate code. Obviously we don't want to do any real refactoring as part of this, but there are a few quick and easy wins that I think are worth it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@swissspidy Looks great! Some suggestions, but nothing critical.
Can you open a Trac ticket for this?
|
In https://github.com/WordPress/wordpress-develop/actions/runs/12413679906/job/34656106232?pr=6515#step:25:50, it downloads the Firefox browser. Do we actually need that? Additionally, there are warnings during the build of Playwright. Could these warnings indicate an issue on their side? If so, it might be worth opening a ticket in their repository. |
|
We don‘t need Firefox and in the step before we actually only install Chromium. But this download comes from wp-scripts, so this would need an enhancement ticket in Gutenberg. Looks like these warnings are for missing audio and video codecs, nothing we‘d need for the tests. |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@swissspidy This looks great to me. I think it's good to be committed, pending the revert of the temporary repository reference change in performance.yml.
What this PR does:
<details>Collect information about object cache hits & misses, flushing cache between runsTrac ticket: https://core.trac.wordpress.org/ticket/62725
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.