Skip to content

#60467 - improve inline note about missing dependencies#6217

Closed
adarshakshatPosimyth wants to merge 0 commit intoWordPress:trunkfrom
adarshakshatPosimyth:trunk
Closed

#60467 - improve inline note about missing dependencies#6217
adarshakshatPosimyth wants to merge 0 commit intoWordPress:trunkfrom
adarshakshatPosimyth:trunk

Conversation

@adarshakshatPosimyth
Copy link
Copy Markdown

Changed greyed out button text 'Activate' to 'Missing conditions'.
Changed dependency note text 'The plugins listed above must be active in order to use this plugin' to 'The plugins listed above must be active in order to use this plugin'.

Trac Ticket : https://core.trac.wordpress.org/ticket/60467

@adarshakshatPosimyth adarshakshatPosimyth marked this pull request as ready for review March 4, 2024 12:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adarshposimyth, swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

if ( $compatible_php && $compatible_wp ) {
if ( $has_unmet_dependencies ) {
$actions['activate'] = _x( 'Activate', 'plugin' ) .
$actions['activate'] = _x( 'Missing conditions', 'plugin' ) .
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$actions['activate'] = _x( 'Missing conditions', 'plugin' ) .
$actions['activate'] = __( 'Unmet requirements' ) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants