Add a label field in the search controller to return localized type for each item#6112
Add a label field in the search controller to return localized type for each item#6112petitphp wants to merge 4 commits intoWordPress:trunkfrom
label field in the search controller to return localized type for each item#6112Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
petitphp
force-pushed
the
feature/add-label-field-to-search-controller
branch
from
2ebfe82 to
5261f7c
Compare
…ch media controller
petitphp
force-pushed
the
feature/add-label-field-to-search-controller
branch
from
5261f7c to
b29f15f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
petitphp
changed the title
label field in the search controller to return localized type for each itemlabel field in the search controller to return localized type for each item
|
It looks like the associated Gutenberg PR hasn't been merged yet. I'm leaving feedback there for now. |
2 participants
This change is related to a PR in gutenberg to display localize name for suggestions in the link component.
This change felt too complex to be added to the gutenberg repository and backported afterward. Also I wanted to be able to update existing tests for the REST search handler.
This PR contain two changes :
labelproperty in theWP_REST_Search_Controllerand update existing handlers to fill this property accordinglyWP_REST_Media_Search_Handlerhandler to uniformize the shape of the data send back by the search endpoint between all types.Trac ticket: https://core.trac.wordpress.org/ticket/61254