Repository navigation
Conversation
|
Hi @expedition-robin-martijn! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
| <?php | ||
| wp_admin_notice( | ||
| '<p class="error"></p>', | ||
| '<p class="notice notice-error"></p>', |
There was a problem hiding this comment.
Not a blocker but in 6.4 we introduce admin notice functions https://core.trac.wordpress.org/ticket/57791 can we use those here?
There was a problem hiding this comment.
This is not a correct usage of the notice-error class; those classes are already added to this admin notice by setting 'type' to 'error'; this class is inside the notice, and is probably expected by a JS selector to insert the notice when it is present. When changing 'error' classes, we only want to be changing them when they're styling the notice, not when they're used internally within the notice.
ghost
closed this
As described in the Trac ticket below,
class="error"is legacy and should be replaced withclass="notice notice-error". In this PR, I have done that.Trac ticket: https://core.trac.wordpress.org/ticket/50402
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.