51466: Disable CORS for QUnit to avoid error. #574
+273
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
force-pushed
the
51466-qunit-cors
branch
from
a27b3fe to
48c5f7a
Compare
Member
Author
Running "qunit:files" (qunit) task
Testing tests/qunit/compiled.html .................................................................................................................................................................................................................................................................................................................OK
Testing tests/qunit/index.html Failed to load resource: net::ERR_FILE_NOT_FOUND
.................................................................................................................................................................................................................................................................................................................OK
|
iandunn
force-pushed
the
51466-qunit-cors
branch
2 times, most recently
from
f853781 to
ddc9e73
Compare
In some environments, QUnit fails with this error: > Access to XMLHttpRequest at 'file:///wp-admin/admin-ajax.php' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, https. Requesting that endpoing via HTTP would require hardcoding a hostname, which would remove the ability of devs to use whatever hostname they want. We don't need to worry about CORS in this context, so it's safe to disable it. Fixes #51446 See gruntjs/grunt-contrib-qunit#158 Props garrett-eclipse
iandunn
force-pushed
the
51466-qunit-cors
branch
from
ddc9e73 to
4e9c61d
Compare
Member
Author
|
I removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QUnit options to disable CORS.
Trac ticket: https://core.trac.wordpress.org/ticket/51446