Repository navigation
Conversation
…ponsive styles for about, contribute, credits, freedom and privacy pages. Fixes issues mentioned in #59289 and #59664
aaronjorbin
reviewed
Oct 26, 2023
aaronjorbin
left a comment
aaronjorbin
left a comment
Member
There was a problem hiding this comment.
Thank you @nudgeD! In general, this is looking great. A couple of things:
- it's generally best to make a branch for a PR rather than use your
trunkbranch. It's not a problem per say, but doing this can make it a bit harder to work on multiple things including testing other patches. Likely not a problem here, but something for future contributions. - Minor: I needed to update some of the path to the images for them to load correctly.
- As I noted on the ticket, the background asterisk doesn't flip for RTL. I think it looks good, but I want to confirm this is a conscious decision. If you want it to be a true RTL with the asterisk on the right, can you add a flipped SVG and I can write the piece to override it on rtl.
| .about__header-title h1 { | ||
| /* Fluid font size scales on browser size 600px - 960px. */ | ||
| font-size: clamp(3rem, 13.33vw - 2rem, 6rem); | ||
| /*font-size: clamp(3rem, 13.33vw - 2rem, 6rem);*/ |
Member
There was a problem hiding this comment.
If this is going to not be used, let's remove the block rather than comment out the property. Or was this accidental testing code you pushed?
Author
There was a problem hiding this comment.
It's been removed. Thanks for catching that.
Author
|
Thanks for this, @aaronjorbin
|
Member
|
Committed in https://core.trac.wordpress.org/changeset/57018 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated colour variables. Updated header graphics for responsive styles for about, contribute, credits, freedom and privacy pages. Fixes issues mentioned in Trac #59289 and #59664