Fix PHP notice that showed when orderby query parameter was an array#5404
Fix PHP notice that showed when orderby query parameter was an array#5404leonidasmi wants to merge 5 commits intoWordPress:trunkfrom
Conversation
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks for the pull request @leonidasmi, I've added a couple of suggestions inline.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me, just a minor nitpick inline.
I've tested it on my local install and it is working as expected.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Trac ticket: https://core.trac.wordpress.org/ticket/59494
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.