Image caption shortcode parameter validation#5375
Image caption shortcode parameter validation#5375BrianHenryIE wants to merge 4 commits intoWordPress:trunkfrom
Conversation
This was confirmed failing without the previous commit – validates that the patch works
src/wp-includes/media.php
Outdated
| * @return string HTML content to display the caption. | ||
| */ | ||
| function img_caption_shortcode( $attr, $content = '' ) { | ||
| /** |
There was a problem hiding this comment.
| /** | |
| /* |
Remove extra star from comment
There was a problem hiding this comment.
That is not suggested by WPCS.
A regex search of the WordPress core codebase for \/\*[^\*]*]\s*$ does not find any example of the suggestion already in use.
There was a problem hiding this comment.
Check Multiline comment formate: https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#5-2-multi-line-comments
|
Such a check was once added in https://core.trac.wordpress.org/changeset/56488 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @piercema@montclair.edu. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 participants
Refresh of #4939
Trac ticket: https://core.trac.wordpress.org/ticket/45929