Skip to content

Add a notice if a theme is requested too early when previewing a theme #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okmttdhr wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add a notice if a theme is requested too early when previewing a theme #5182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/wp-includes/theme-previews.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,36 @@ function wp_block_theme_activate_nonce() {
<?php
}

/**
* Add `_doing_it_wrong()` notice if the theme is requested before `pluggable.php` is loaded.
*
* @since 6.3.2
* @param string $current The current theme's stylesheet or template path.
* @return string Return the current theme's stylesheet or template path as is.
*/
function wp_theme_preview_maybe_doing_it_wrong( $current ) {
if ( ! empty( $_GET['wp_theme_preview'] ) && ! function_exists( 'wp_get_current_user' ) ) {
if ( current_filter() === 'template' ) {
$function_name = 'get_template()';
} else {
$function_name = 'get_stylesheet()';
}

_doing_it_wrong(
$function_name,
sprintf(
/* translators: translators: Developer debugging message. 1: PHP function name */
__( 'Calling %s before pluggable.php has loaded can result in getting the current theme instead of the previewed theme. Please ensure that you are using these functions after the plugins_loaded action has fired if this is not intended.' ),
$function_name
),
'6.3.2'
);
}
return $current;
}
add_filter( 'stylesheet', 'wp_theme_preview_maybe_doing_it_wrong' );
add_filter( 'template', 'wp_theme_preview_maybe_doing_it_wrong' );

/**
* Add filters and actions to enable Block Theme Previews in the Site Editor.
*
Expand Down