Invalidate wp_core_block_css_files transient when files' path and includes path doesn't match#5112
Closed
petitphp wants to merge 1 commit intoWordPress:trunkfrom
Closed
Invalidate wp_core_block_css_files transient when files' path and includes path doesn't match#5112petitphp wants to merge 1 commit intoWordPress:trunkfrom
wp_core_block_css_files transient when files' path and includes path doesn't match#5112petitphp wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…ncludes path doesn't match
mukeshpanchal27
approved these changes
Aug 31, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @petitphp for the PR. LGTM!
spacedmonkey
approved these changes
Sep 5, 2023
Author
|
Closing in favor of #5052 (already merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative solution for 59111 based on the comment 17 from spacedmonkey.
This PR add a check after getting the value for the
wp_core_block_css_filestransient, to verify that the start of the files' path match the current includes path.Trac ticket: https://core.trac.wordpress.org/ticket/59111
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.