Updated: Use 6th parmeter of wp_enqueue_script() and wp_register_script()#5073
Closed
mrinal013 wants to merge 6 commits intoWordPress:trunkfrom
Closed
Updated: Use 6th parmeter of wp_enqueue_script() and wp_register_script()#5073mrinal013 wants to merge 6 commits intoWordPress:trunkfrom
mrinal013 wants to merge 6 commits intoWordPress:trunkfrom
Conversation
In the @nirav7707's PR, at twentytwentyone/functions.php line WordPress#424, 433 wp_register_script() missed array at 6th paramerter. Here, added this. Ticket: https://core.trac.wordpress.org/ticket/58634
felixarntz
requested changes
Aug 29, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mrinal013 Thank you for the updated PR! Looks good mostly, just one thing that needs to be addressed.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
felixarntz
approved these changes
Sep 6, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thank you @mrinal013, LGTM!
Member
|
Committed in https://core.trac.wordpress.org/changeset/56526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR, at twentytwentyone/functions.php line #424, 433 wp_register_script() missed array at 6th parameter. Here, added this.
Trac Ticket: https://core.trac.wordpress.org/ticket/58634
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.