Repository navigation
Conversation
@PARAM comment added on line 371
hz-tyfoon
reviewed
Aug 9, 2023
| * @since 4.4.0 | ||
| * | ||
| * @param string $name | ||
| * @param string $name Post name. |
There was a problem hiding this comment.
Seems good.
But in the docblock of __isset method, the comment used is Property name & not post name. see line 354.
Looks like, it'd be consistent if same comment is used for both cases.
Member
There was a problem hiding this comment.
Indeed, this is a property name, not a post name.
|
Thanks @Armondal for the PR. It looks good to me. |
Contributor
|
committed in https://core.trac.wordpress.org/changeset/56433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is for code review only. Please keep all other discussions in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.