Applying patch from jack-h2ml to current wp version#4788
Closed
gturpin-dev wants to merge 3 commits intoWordPress:trunkfrom
Closed
Applying patch from jack-h2ml to current wp version#4788gturpin-dev wants to merge 3 commits intoWordPress:trunkfrom
gturpin-dev wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @gturpin-dev for the PR, left some initial feedback.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
tellthemachines
approved these changes
Jul 10, 2023
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Code LGTM and can confirm it works as expected in testing. Thanks for fixing this!
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/56183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57566