Backport 6.3: REST API Template Controller ignore empty templates#4689
Closed
ramonjd wants to merge 2 commits intoWordPress:trunkfrom
Closed
Backport 6.3: REST API Template Controller ignore empty templates#4689ramonjd wants to merge 2 commits intoWordPress:trunkfrom
ramonjd wants to merge 2 commits intoWordPress:trunkfrom
Conversation
This was referenced Jun 25, 2023
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Show resolved
Hide resolved
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
ramonjd
force-pushed
the
update/rest-template-controller-callback
branch
from
89ed89f to
f377ce7
Compare
youknowriad
approved these changes
Jun 26, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting changes from WordPress/gutenberg#46248
Ignore empty templates when looking up a fallback template.
I've copied the changes across from WordPress/gutenberg#46248 but might need a second eye from @jorgefilipecosta or @youknowriad to confirm.
props @jorgefilipecostac
Test
npm run test:php -- --filter Tests_REST_WpRestTemplatesControllerTrac ticket: https://core.trac.wordpress.org/ticket/58615
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.